FIO-8798: updated day component validation #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 20, 2024
Merged
johnformio
requested changes
Aug 21, 2024
| month = values[MONTH], | ||
| year = values[YEAR], | ||
| maxDay = getDaysInMonthCount(month, year); | ||
| let [DAY, MONTH, YEAR] = (component as DayComponent).dayFirst ? [0, 1, 2] : [1, 0, 2]; |
There was a problem hiding this comment.
Use the isDayComponent type guard so you don't have to cast component everywhere
TanyaGashtold
approved these changes
Aug 23, 2024
7 tasks
TanyaGashtold
approved these changes
Aug 26, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-8798
Description
Day component validation was changed.
The changes were caused by a change in the formation of the data string for the Day component with hidden fields.
if a element of the day component is hidden, it should be excluded from the string instead of populating with ‘00’
Examples (new years):
day / year == ‘01/2024’
month / year = ‘01/2024’
day / month = ‘01/01’
Breaking Changes / Backwards Compatibility
How has this PR been tested?
autotests
Checklist: