FIO-8798: updated shape of the data of day component with hidden fields #5760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
TanyaGashtold
requested changes
Aug 23, 2024
| values[YEAR] === '0000' || | ||
| values[DAY] === '' || | ||
| values[MONTH] === '' || | ||
| values[YEAR] === ''); | ||
| } | ||
|
|
||
| getValidationFormat() { |
There was a problem hiding this comment.
Does this method still work when some part of date is hidden?
7 tasks
Maria-Golomb
force-pushed
the
FIO-8798-update-day-component
branch
from
2976aed
to
9e85e8c
Compare
TanyaGashtold
approved these changes
Aug 26, 2024
lane-formio
pushed a commit
that referenced
this pull request
Aug 28, 2024
…ds (#5760) * FIO-8798: updated shape of the data of day component with hidden fields * FIO-8798: add conditionOperatorsSettings for Day component * FIO-8798: update core version * FIO-8798: add yarn.lock * Revert "FIO-8798: add yarn.lock" This reverts commit 80c5127. * Revert "FIO-8798: update core version" This reverts commit 12a30c3. * FIO-8798: update validation format * FIO-8798: update partial day check
lane-formio
pushed a commit
that referenced
this pull request
Sep 5, 2024
…ds (#5760) * FIO-8798: updated shape of the data of day component with hidden fields * FIO-8798: add conditionOperatorsSettings for Day component * FIO-8798: update core version * FIO-8798: add yarn.lock * Revert "FIO-8798: add yarn.lock" This reverts commit 80c5127. * Revert "FIO-8798: update core version" This reverts commit 12a30c3. * FIO-8798: update validation format * FIO-8798: update partial day check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-8798
Description
The formation of the data string for the Day component with hidden fields was changed.
if a element of the day component is hidden, it should be excluded from the string instead of populating with ‘00’
Examples (new years):
day / year == ‘01/2024’
month / year = ‘01/2024’
day / month = ‘01/01’
Why have you chosen this solution?
Use this section to justify your choices
Breaking Changes / Backwards Compatibility
Use this section to describe any potentially breaking changes this PR introduces or any effects this PR might have on backwards compatibility
Dependencies
formio/core#140
How has this PR been tested?
autotests
Checklist: