Fill out notofonts profile with checks from notolint #3681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipesanches
requested changes
Mar 29, 2022
There was a problem hiding this comment.
Thanks for the PR, @simoncozens Please also create entries for all the new notofonts checks in our CHANGELOG.md file, referencing this PR.
|
I agree with Felipe, but actually an increasing amount of Noto fonts have
multiple copyright holders so we should move them all to the gf standard
notice (Project Authors)
|
|
oh! All these new checks are currently lacking code-tests. What's your plan, @simoncozens? |
Plan? I'm just making stuff up as I go along, as usual. :-) I'll get some tests added. |
|
fair enough ;-) |
|
I will merge this because it is useful, but please consider sending a followup PR including code-tests for these newly added checks. |
This reverts commit ed77cea.
|
Thank you! I did start working on tests today but other things took priority. Will try to finish up by end of week. |
|
cool! thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The nototools repository is going away soon. Because of this, we want to (finally) move all the checks from notolint into the notofonts profile. This implements the salient ones.
To Do
CHANGELOG.md