Skip to content

Commit

Permalink
Fill out notofonts profile with checks from notolint
Browse files Browse the repository at this point in the history
* All Noto fonts should pass GF checks (since they're also intended to be Google Fonts)
(PR #3681)
  • Loading branch information
simoncozens authored Apr 5, 2022
1 parent 69bd7ac commit e94b0d6
Show file tree
Hide file tree
Showing 3 changed files with 444 additions and 7 deletions.
13 changes: 13 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,19 @@ A more detailed list of changes is available in the corresponding milestones for
#### On the Universal Profile
- **[com.google.fonts/check/gpos7]:** Previously we checked for the existence of GSUB 5 lookups in the erroneous belief that they were not supported; GPOS 7 lookups are not supported in CoreText, but GSUB 5 lookups are fine. (issue #3689)

### New Checks
#### Added to the Noto Fonts Profile
- The majority of checks from the Google Fonts profile have been added. (PR #3681)
- **[com.google.fonts/check/name/noto_manufacturer]:** Checks for a known manufacturer name and correct designer URL in the name table. (PR #3681)
- **[com.google.fonts/check/name/noto_designer]:** Checks for a known designer name. (PR #3681)
- **[com.google.fonts/check/name/noto_trademark]:** Checks that the trademark entry in the name table is correct. (PR #3681)
- **[com.google.fonts/check/cmap/format_12]:** Checks that format 12 cmap tables are used appropriately. (PR #3681)
- **[com.google.fonts/check/os2/noto_vendor]:** Checks that the vendor ID in the OS/2 table is set to GOOG. (PR #3681)
- **[com.google.fonts/check/hmtx/encoded_latin_digits]:** Checks that any encoded Latin digits have equal advance width. (PR #3681)
- **[com.google.fonts/check/hmtx/comma_period]:** Checks that the comma and period glyphs have the same advance width as each other. (PR #3681)
- **[com.google.fonts/check/hmtx/whitespace_advances]:** Checks that whitespace glyphs have expected advance widths. (PR #3681)
- **[com.google.fonts/check/cmap/alien_codepoints]:** Checks that there are no surrogate pair or private use area codepoints encoded in the cmap table. (PR #3681)


## 0.8.8 (2022-Mar-23)
### Noteworthy code-changes
Expand Down
2 changes: 1 addition & 1 deletion Lib/fontbakery/codetesting.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def _get_args(self, condition_overrides=None):
# args that are derived iterables are generators that must be
# converted to lists, otherwise we end up with exhausted
# generators after their first consumption.
for k in args:
for k in args.keys():
if self.profile.get_type(k, None) == 'derived_iterables':
args[k] = list(args[k])
return args
Expand Down
Loading

0 comments on commit e94b0d6

Please sign in to comment.