Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Timezone difference in error timestamp unit tests #2953

Merged
merged 2 commits into from
Nov 26, 2024
Merged

[BUG] Timezone difference in error timestamp unit tests #2953

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
152e07f
fix: set timezone to utc
mao3267 Nov 25, 2024
401c5ec
Merge branch 'master' of https://github.com/mao3267/flytekit into fix…
mao3267 Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tests/flytekit/unit/bin/test_python_entrypoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,12 @@ def test_get_traceback_str():
assert expected_error_re.match(traceback_str) is not None


def test_get_container_error_timestamp() -> None:
def test_get_container_error_timestamp(monkeypatch) -> None:
# Set the timezone to UTC
monkeypatch.setenv("TZ", "UTC")
if hasattr(time, 'tzset'):
time.tzset()

assert get_container_error_timestamp(FlyteException("foo", timestamp=10.5)) == Timestamp(seconds=10, nanos=500000000)

current_dtime = datetime.now()
Expand Down
Loading