Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Timezone difference in error timestamp unit tests #2953

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

mao3267
Copy link
Contributor

@mao3267 mao3267 commented Nov 25, 2024

Tracking issue

None

Why are the changes needed?

While running CI tests locally, it turns out that the time from datatime.now() is not using UTC timezone, causing errors while comparing current time and error time.

image

What changes were proposed in this pull request?

  1. Set the timezone to UTC using monkeypatch.

How was this patch tested?

  1. Using make unit_test to make sure all existing tests pass.

Setup process

git clone https://github.com/flytorg/flytekit.git
gh pr checkout 2952
pip install -e .

Screenshots

image

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

None

Docs link

None

@wild-endeavor
Copy link
Contributor

oops, ignore previous comment.

@mao3267
Copy link
Contributor Author

mao3267 commented Nov 26, 2024

The CI Error is caused by the Mashumaro update to 3.15. #2952 is the PR working on this fix.

@Future-Outlier Future-Outlier merged commit f938661 into flyteorg:master Nov 26, 2024
103 of 104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants