[WIP] [Test] [BUG] Unit tests for dataclass in union with more than two non-None variants #2952
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Related to flyteorg/flyte#5986
Why are the changes needed?
After mashumaro release version
3.15
, it supports messagepack robust decoding with the correct type in Union. Therefore, we would like to add a unit test to show it works. Also, we should fix errors to support changes in mashumaro to version3.15
.What changes were proposed in this pull request?
dataclass_json
ingenerate_attribute_list_from_dataclass_json
function.additionalProperties
to generate dataclass properties. However, both dataclass and dictionary type can have anadditionalProperties
field. This mismatch causes the bug of generating an incorrect attribute list for dictionaries.How was this patch tested?
Setup process
Screenshots
None
Check all the applicable boxes
Related PRs
#2859
Fatal1ty/mashumaro#256
Docs link
None
Note