Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flyteagent] Remove redundant code in Agent #5454

Merged
merged 4 commits into from
Jun 14, 2024

Remove defer func() by pingsu's advice.

fce16bf
Select commit
Loading
Failed to load commit list.
Merged

[flyteagent] Remove redundant code in Agent #5454

Remove defer func() by pingsu's advice.
fce16bf
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jun 8, 2024 in 0s

61.01% (-0.07%) compared to 25c3596

View this Pull Request on Codecov

61.01% (-0.07%) compared to 25c3596

Details

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 61.01%. Comparing base (25c3596) to head (fce16bf).
Report is 1 commits behind head on master.

Files Patch % Lines
...yteplugins/go/tasks/plugins/webapi/agent/client.go 50.00% 1 Missing and 1 partial ⚠️
...yteplugins/go/tasks/plugins/webapi/agent/plugin.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5454      +/-   ##
==========================================
- Coverage   61.07%   61.01%   -0.07%     
==========================================
  Files         793      793              
  Lines       51226    51289      +63     
==========================================
+ Hits        31288    31292       +4     
- Misses      17062    17119      +57     
- Partials     2876     2878       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.