-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flyteagent] Remove redundant code in Agent #5454
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5454 +/- ##
==========================================
- Coverage 61.07% 61.01% -0.07%
==========================================
Files 793 793
Lines 51226 51289 +63
==========================================
+ Hits 31288 31292 +4
- Misses 17062 17119 +57
- Partials 2876 2878 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Future-Outlier
commented
Jun 7, 2024
Future-Outlier
commented
Jun 7, 2024
pingsutw
reviewed
Jun 8, 2024
Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: pingsutw <[email protected]>
pingsutw
approved these changes
Jun 14, 2024
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this pull request
Jul 2, 2024
* Remove Redundant code in Agent Signed-off-by: Future-Outlier <[email protected]> * improve error messages Signed-off-by: Future-Outlier <[email protected]> * change to Signed-off-by: Future-Outlier <[email protected]> * Remove defer func() by pingsu's advice. Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: pingsutw <[email protected]> --------- Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: pingsutw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
#3936
Why are the changes needed?
Comment in the description below.
What changes were proposed in this pull request?
How was this patch tested?
single binary.
Setup process
Screenshots
Check all the applicable boxes