Update access checks #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the plugin checked, if the user holds the global admin role. To enable persons who have proper authority, but not the global admin role to configure the plungin settings, I introduced a new function "grant access(): bool" to the plugin class. The checks fpr the pluginGUI, UDFChecks, UserSettings and UserSearch are updated to use the new function.
The Function itself checks if the user is allowed to edit roles in ILIAS user adminstration, since most functions of the plugin (de-)assign roles to users. Probably this could be extended to check orgUnit assignment capabilities, too.
if other capabilities should be honoured, this can be achieved in one place now.
I did not touch the REST API related classes since I am not sure which check should be placed here.