Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserDefaults can only be configured by admins #26

Open
ingoj opened this issue Mar 26, 2024 · 0 comments
Open

UserDefaults can only be configured by admins #26

ingoj opened this issue Mar 26, 2024 · 0 comments

Comments

@ingoj
Copy link
Contributor

ingoj commented Mar 26, 2024

The plugin only alows admins to configure the plugin (by checking if globel role 2 is held by the current user.
It should be possible to configure the plugin for non-globel admins (other plugins often do not check anything and rely on visibility of plugin adminstration to the user).

PR #25 addresses this and checks, if the current user is allowed to change role assignments in user adminsitration. Since most functions of UserDefaults (de-)assign roles to users, this could be an adequate behviour of the plugin.

Other solutions are defintiively possible and appreciated.

REST API access is not touched by the PR and still require global admin role (could be changed easiy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant