-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpm: add confluent (kafka) test case #661
Conversation
124661c
to
3a7e71e
Compare
ab4b9e9
to
00a11df
Compare
NOTE enable serverspec recipe again. |
d31a847
to
fb07623
Compare
kafka spec is not properly executed yet. |
a2d0a85
to
447f6e3
Compare
hmm, confluent test case with deb succeeds, but not for rpm. |
447f6e3
to
32e08a2
Compare
Should be rebased after #665 was merged. |
b3683a4
to
7631ab3
Compare
got it. needless limitation of CentOS 8 Stream era blocked it. |
7631ab3
to
ef4cdd9
Compare
ef4cdd9
to
7e5c999
Compare
macOS failure is out of scope: See #666 |
just recheck it again. |
761bb1d
to
3ee01c5
Compare
Fixed unexpected failure on debian. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I commented on a few points of concern.
test packaged rdkafka usability. Signed-off-by: Kentaro Hayashi <[email protected]>
And raise baseline of OpenJDK version and Confluent. Signed-off-by: Kentaro Hayashi <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
kafka related test case was extracted into confluent-test.sh. Signed-off-by: Kentaro Hayashi <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
In the past versions, CentOS 8 Stream should be excluded, but there is no such a exception. Instead, it is harmful that serverspec test case is not executed. so just replace it. Signed-off-by: Kentaro Hayashi <[email protected]>
In the past versions, CentOS 8 Stream should be excluded, but there is no such a exception. Instead, it is harmful that serverspec test case is not executed. so just replace it. Signed-off-by: Kentaro Hayashi <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
3ee01c5
to
74ee44f
Compare
Fixed based on feedback. |
As we need to handle *whole string" as input, using $0 is correct. (though as it doesn't contains separator, $0/$1 seems same for awk) Signed-off-by: Kentaro Hayashi <[email protected]>
74ee44f
to
d81f8b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
waiting CI to be sure. |
test packaged rdkafka usability.