Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpm: add confluent (kafka) test case #661

Merged
merged 11 commits into from
Jul 29, 2024
Merged

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Jul 23, 2024

test packaged rdkafka usability.

  • Refactor confluent test case (Unify some script)
  • Changed to execute confluent test with AlmaLinux, Amazon Linux and so on
  • Drop limitation not to execute on Amazon Linux 2/2023

@kenhys kenhys force-pushed the rpm-confluent-test branch 3 times, most recently from 124661c to 3a7e71e Compare July 23, 2024 04:16
@kenhys kenhys mentioned this pull request Jul 23, 2024
10 tasks
@kenhys kenhys force-pushed the rpm-confluent-test branch 7 times, most recently from ab4b9e9 to 00a11df Compare July 23, 2024 05:35
@kenhys
Copy link
Contributor Author

kenhys commented Jul 23, 2024

NOTE enable serverspec recipe again.

@kenhys kenhys force-pushed the rpm-confluent-test branch 4 times, most recently from d31a847 to fb07623 Compare July 24, 2024 06:44
@kenhys
Copy link
Contributor Author

kenhys commented Jul 24, 2024

kafka spec is not properly executed yet.

@kenhys kenhys force-pushed the rpm-confluent-test branch 4 times, most recently from a2d0a85 to 447f6e3 Compare July 24, 2024 09:03
@kenhys
Copy link
Contributor Author

kenhys commented Jul 24, 2024

hmm, confluent test case with deb succeeds, but not for rpm.

@kenhys kenhys force-pushed the rpm-confluent-test branch from 447f6e3 to 32e08a2 Compare July 25, 2024 03:13
@kenhys
Copy link
Contributor Author

kenhys commented Jul 26, 2024

Should be rebased after #665 was merged.

@kenhys kenhys force-pushed the rpm-confluent-test branch 4 times, most recently from b3683a4 to 7631ab3 Compare July 29, 2024 03:53
@kenhys
Copy link
Contributor Author

kenhys commented Jul 29, 2024

got it. needless limitation of CentOS 8 Stream era blocked it.

@kenhys kenhys force-pushed the rpm-confluent-test branch from 7631ab3 to ef4cdd9 Compare July 29, 2024 03:59
@kenhys kenhys force-pushed the rpm-confluent-test branch from ef4cdd9 to 7e5c999 Compare July 29, 2024 04:41
@kenhys kenhys requested a review from daipom July 29, 2024 05:11
@kenhys kenhys marked this pull request as ready for review July 29, 2024 05:11
@kenhys
Copy link
Contributor Author

kenhys commented Jul 29, 2024

macOS failure is out of scope: See #666

@kenhys kenhys removed the request for review from daipom July 29, 2024 05:13
@kenhys
Copy link
Contributor Author

kenhys commented Jul 29, 2024

just recheck it again.

@kenhys kenhys force-pushed the rpm-confluent-test branch from 761bb1d to 3ee01c5 Compare July 29, 2024 05:18
@kenhys kenhys requested a review from daipom July 29, 2024 05:19
@kenhys
Copy link
Contributor Author

kenhys commented Jul 29, 2024

Fixed unexpected failure on debian.

Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I commented on a few points of concern.

.github/workflows/yum.yml Outdated Show resolved Hide resolved
fluent-package/apt/confluent-test.sh Show resolved Hide resolved
fluent-package/yum/confluent-test.sh Outdated Show resolved Hide resolved
kenhys added 10 commits July 29, 2024 16:17
test packaged rdkafka usability.

Signed-off-by: Kentaro Hayashi <[email protected]>
And raise baseline of OpenJDK version and Confluent.

Signed-off-by: Kentaro Hayashi <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
kafka related test case was extracted into confluent-test.sh.

Signed-off-by: Kentaro Hayashi <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
In the past versions, CentOS 8 Stream should be excluded,
but there is no such a exception. Instead, it is harmful that
serverspec test case is not executed. so just replace it.

Signed-off-by: Kentaro Hayashi <[email protected]>
In the past versions, CentOS 8 Stream should be excluded,
but there is no such a exception. Instead, it is harmful that
serverspec test case is not executed. so just replace it.

Signed-off-by: Kentaro Hayashi <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys kenhys force-pushed the rpm-confluent-test branch from 3ee01c5 to 74ee44f Compare July 29, 2024 07:29
@kenhys
Copy link
Contributor Author

kenhys commented Jul 29, 2024

Fixed based on feedback.

As we need to handle *whole string" as input, using $0 is correct.
(though as it doesn't contains separator, $0/$1 seems same for awk)

Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys kenhys force-pushed the rpm-confluent-test branch from 74ee44f to d81f8b7 Compare July 29, 2024 07:56
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kenhys
Copy link
Contributor Author

kenhys commented Jul 29, 2024

waiting CI to be sure.

@kenhys kenhys mentioned this pull request Jul 29, 2024
@kenhys kenhys merged commit 2a885c3 into fluent:master Jul 29, 2024
54 checks passed
@kenhys kenhys deleted the rpm-confluent-test branch July 29, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants