Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fluent-package v5.1.0 #660

Closed
10 tasks done
kenhys opened this issue Jul 19, 2024 · 31 comments
Closed
10 tasks done

fluent-package v5.1.0 #660

kenhys opened this issue Jul 19, 2024 · 31 comments
Milestone

Comments

@kenhys
Copy link
Contributor

kenhys commented Jul 19, 2024

Tracking v5.1.0 issues still in development.

@kenhys kenhys changed the title v5.1.0 fluent-package v5.1.0 Jul 22, 2024
@kenhys kenhys added this to the 5.1.0 (T.B.D.) milestone Jul 22, 2024
@kenhys
Copy link
Contributor Author

kenhys commented Jul 22, 2024

bundled gem size was increased. (~5MB)

5 0 4

5 1 0

@kenhys
Copy link
Contributor Author

kenhys commented Jul 22, 2024

mainly rdkafka upgrade affect it.( 2.3MB=>7.2MB )

@kenhys
Copy link
Contributor Author

kenhys commented Jul 22, 2024

need to relax limitation for a while.

@kenhys
Copy link
Contributor Author

kenhys commented Jul 22, 2024

ffi 1.16.3 can't be built on AmazonLinux 2.

https://github.com/fluent/fluent-package-builder/actions/runs/10034848340/job/27729984596

@kenhys
Copy link
Contributor Author

kenhys commented Jul 22, 2024

rdkafka 0.16.1 is not correctly built?

@kenhys
Copy link
Contributor Author

kenhys commented Jul 22, 2024

If rdkafka was reverted to 0.16.0, package size was not so increased. (may be no need to relax limitation )

@kenhys
Copy link
Contributor Author

kenhys commented Jul 22, 2024

rdkafka 0.16.0 is buldable, but not available in colfluent test.

@kenhys
Copy link
Contributor Author

kenhys commented Jul 22, 2024

/opt/fluent/bin/gem list |grep rdkafka
rdkafka (0.16.0)

rdkafka was installed. but not recognized... 🤔

@kenhys
Copy link
Contributor Author

kenhys commented Jul 22, 2024

rdkafka 0.16.0 was installed at:

~$ find /opt/fluent/ -name '*rdkafka*'
/opt/fluent/lib/ruby/gems/3.2.0/specifications/rdkafka-0.16.0.gemspec
/opt/fluent/lib/ruby/gems/3.2.0/gems/rdkafka-0.16.0
/opt/fluent/lib/ruby/gems/3.2.0/gems/rdkafka-0.16.0/lib/rdkafka
/opt/fluent/lib/ruby/gems/3.2.0/gems/rdkafka-0.16.0/lib/rdkafka.rb
/opt/fluent/lib/ruby/gems/3.2.0/gems/rdkafka-0.16.0/ext/librdkafka.so
/opt/fluent/lib/ruby/gems/3.2.0/gems/rdkafka-0.16.0/rdkafka.gemspec
/opt/fluent/lib/ruby/gems/3.2.0/gems/fluent-plugin-kafka-0.19.2/lib/fluent/plugin/in_rdkafka_group.rb
/opt/fluent/lib/ruby/gems/3.2.0/gems/fluent-plugin-kafka-0.19.2/lib/fluent/plugin/out_rdkafka.rb
/opt/fluent/lib/ruby/gems/3.2.0/gems/fluent-plugin-kafka-0.19.2/lib/fluent/plugin/out_rdkafka2.rb
/opt/fluent/lib/ruby/gems/3.2.0/extensions/x86_64-linux/3.2.0/rdkafka-0.16.0

@kenhys
Copy link
Contributor Author

kenhys commented Jul 22, 2024

The rdkafka failure is caused by removing gem.build_complete.

@kenhys
Copy link
Contributor Author

kenhys commented Jul 22, 2024

https://github.com/fluent/fluent-package-builder/actions/runs/10036365251/job/27733978175

windows_platforms = [:mingw, :x64_mingw] # :mswin
gem "ffi", "1.16.3", platforms: windows_platforms

Thus, platforms: does not work as expected on AmazonLinux 2.

@kenhys
Copy link
Contributor Author

kenhys commented Jul 22, 2024

+ /usr/lib/rpm/brp-python-bytecompile /usr/bin/python 1
Compiling /root/rpmbuild/BUILDROOT/fluent-package-5.1.0-1.amzn2.x86_64/opt/fluent/lib/ruby/gems/3.2.0/gems/ffi-1.16.3/ext/ffi_c/libffi/generate-darwin-source-and-headers.py ...

And during building debuinfo?, unexpectedly bytecompile process was kicked.

@kenhys
Copy link
Contributor Author

kenhys commented Jul 22, 2024

And during building debuinfo?, unexpectedly bytecompile process was kicked.

Same result (v1.17.0) on AmazonLinux 2.

@kenhys
Copy link
Contributor Author

kenhys commented Jul 22, 2024

@kenhys
Copy link
Contributor Author

kenhys commented Jul 22, 2024

@kenhys
Copy link
Contributor Author

kenhys commented Jul 23, 2024

container ea60ff1bf4515e0721f4583107bf62c2fee67b8fe97b9435ff8ca5bf4d1a295c encountered an error during hcs::System::Start: context deadline exceeded

it may be resolved with retry.

@kenhys
Copy link
Contributor Author

kenhys commented Jul 23, 2024

Check whether rdkafka 0.16.0 => 0.16.1 upgrade can be bundled or not again.
(as gem build_complete issue was resolved)

@kenhys
Copy link
Contributor Author

kenhys commented Jul 23, 2024

Blocker issue on Windows:

Downloading fluent-plugin-webhdfs-1.6.0 revealed dependencies not in the API or 
the lockfile (webhdfs (>= 0.11.0)).
Either installing with `--full-index` or running `bundle update
fluent-plugin-webhdfs` should fix the problem.
rake aborted!

@kenhys
Copy link
Contributor Author

kenhys commented Jul 23, 2024

Note: confluent community can't be installed on AmazonLinux (via package management)

@kenhys
Copy link
Contributor Author

kenhys commented Jul 23, 2024

Note: confluent community can't be installed on AmazonLinux (via package management)

Precisely, confluent-client repository is not supported.

@kenhys
Copy link
Contributor Author

kenhys commented Jul 23, 2024

@kenhys
Copy link
Contributor Author

kenhys commented Jul 24, 2024

kafka related test case is bit out-dated. so refactor it now.

@kenhys
Copy link
Contributor Author

kenhys commented Jul 29, 2024

NOTE:

Now macOS workflow always fails because of refreshed runner image

https://github.com/fluent/fluent-package-builder/actions/runs/10105868174/job/27947051208
macos-14-arm64 20240722.3 causes failure.

https://github.com/fluent/fluent-package-builder/actions/runs/10091587427/job/27903442530
until version macos-14-arm64 20240714.2, it succeeds.

@kenhys
Copy link
Contributor Author

kenhys commented Jul 29, 2024

recently nokogiri 1.16.7 was released, catch up it.

@kenhys
Copy link
Contributor Author

kenhys commented Jul 29, 2024

recently nokogiri 1.16.7 was released, catch up it.

done.

@kenhys
Copy link
Contributor Author

kenhys commented Jul 30, 2024

We need to tackle windows build failure...

@kenhys
Copy link
Contributor Author

kenhys commented Jul 30, 2024

Try to update to ruby 3.2.5.

@kenhys
Copy link
Contributor Author

kenhys commented Jul 30, 2024

We need to tackle windows build failure...

Noticed that nokogiri 1.16.7 fails to build on windows, but not reproducible now...

@kenhys
Copy link
Contributor Author

kenhys commented Jul 31, 2024

build process on arm works as expected.

@kenhys
Copy link
Contributor Author

kenhys commented Aug 5, 2024

Even though some fixes for script are needed, but it works well with switching signing key.
checked with test/experimental/5 repository.

@kenhys
Copy link
Contributor Author

kenhys commented Aug 5, 2024

Done!

@kenhys kenhys closed this as completed Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant