Use Storyteller for handling all of our Story/Storybook needs #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buggy, but it's progress
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Our org has a new package for handling all Story and Storybook logic we previously had baked into flipbook in the form of Storyteller.
https://github.com/flipbook-labs/storyteller
Solution
This PR adds Storyteller to our dependencies and starts consuming it. All Story and Storybook related logic has been stripped out and migrated over
As a bonus, Storyteller gives us Fusion support out of the box.
Closes #225
Checklist
lune run testlocally before mergingKnown issues
We have one test failure for ArrayControls.story.luau though I've tested it out manually in flipbook and it seems to behave fine. Not sure what the root issue is here but I'll try to come back around to it later