Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin scanning #4

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Fix plugin scanning #4

merged 1 commit into from
Sep 29, 2023

Commits on Sep 26, 2023

  1. Fix plugin scanning

    During plugin scanning, Helio is launching itself as a child process,
    and due to perhaps what is a JUCE limitation, it cannot cope with
    being launched as `helio` (even though the `helio` binary is on
    `$PATH`). It seems Helio must be launched with an absolute path to the
    binary for plugin scanning to work.
    
    Broken:
    
    ```
    $ flatpak run --command=helio fm.helio.Workstation
    Safe scanning: /app/extensions/Plugins/vst3/Dexed.vst3
    JUCE Assertion failure in juce_posix_SharedCode.h:1100
    Done scanning for audio plugins
    
    $ flatpak run --devel --command=bash fm.helio.Workstation -c 'echo $PATH'
    /app/bin:/usr/bin
    ```
    
    Working:
    
    ```
    $ flatpak run --command=/app/bin/helio fm.helio.Workstation
    Safe scanning: /app/extensions/Plugins/vst3/Dexed.vst3
    Done scanning for audio plugins
    ```
    
    Fixes: flathub#1
    jistr committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    0c30ea3 View commit details
    Browse the repository at this point in the history