Fix plugin scanning #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During plugin scanning, Helio is launching itself as a child process, and due to perhaps what is a JUCE limitation, it cannot cope with being launched as `helio` (even though the `helio` binary is on `$PATH`). It seems Helio must be launched with an absolute path to the binary for plugin scanning to work. Broken: ``` $ flatpak run --command=helio fm.helio.Workstation Safe scanning: /app/extensions/Plugins/vst3/Dexed.vst3 JUCE Assertion failure in juce_posix_SharedCode.h:1100 Done scanning for audio plugins $ flatpak run --devel --command=bash fm.helio.Workstation -c 'echo $PATH' /app/bin:/usr/bin ``` Working: ``` $ flatpak run --command=/app/bin/helio fm.helio.Workstation Safe scanning: /app/extensions/Plugins/vst3/Dexed.vst3 Done scanning for audio plugins ``` Fixes: flathub#1
|
Started test build 68988 |
|
Build 68988 failed |
|
you should patch JUCE instead. It's just wronng. For the record this was working previously but I guess it got broken and I didn't realise. |
|
They have some non-OSS licencing so i'll report an issue for them. But i think the flatpak patch here shouldn't hurt either? It could be a long time before this is fixed in JUCE and bubbles through into Helio. |
|
When it's broken, it's broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During plugin scanning, Helio is launching itself as a child process, and due to perhaps what is a JUCE limitation, it cannot cope with being launched as
helio(even though theheliobinary is on$PATH). It seems Helio must be launched with an absolute path to the binary for plugin scanning to work.Broken:
Working:
Fixes: #1