sbpf: undo rodata footprint optimization #1058
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit increases the ELF loader's rodata_footprint to be equal
to the ELF file size. This increases memory usage by 5-10% for most
contracts.
The ELF loader made an incorrect assumption that relocations outside
of the rodata segment are invisible to the virtual machine. The
loader therefore reduced the rodata segment size and skipped those
relocations.
This is problematic for two reasons:
and conditionally fails loading depending on the content that was
read.
within a 64-bit value. Chaining those relocations thus allows
moving information from outside the rodata segment into the
rodata segment.
fd_sbpf_loader would have the wrong execution result in both cases.