-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodeinfo: add more nodeinfo #63
Conversation
Ah, I get it -.-' |
yeah, i would appreciate a saver and non error throwing suggestion for the conversion Otherwise this should be okay. |
What default values would you like |
|
The Node should have no location if nothing is configured (like it is currently with mesh-announce or gluon Nodes). I don't know about the best approach to get to this result. |
I'd go with either
Which follows your default in your example config; Or this:
Which I understood is the behavior described in your last comment? |
d0739c1
to
826140b
Compare
I choose the first approach. The other didn't work (or had much noise about the missing Var). @TobleMiner What do you think? Could this be merged? |
Tested without the last force push; broken, if no coordinates were provided. sn07 now runs with both #64 and #63 merged into master.
edit: Testing is done, reverted back to master. |
One possible enhancemnt I just came across is configparsers |
826140b
to
ed25d33
Compare
I did another Force Push to implement it with the I like that approach much more then catching exceptions and it seems to do exactly what is needed. 👍 |
The following things can now be controlled domain specific: Hostname, Hardware-Model, Contact Information, VPN, Latitude and Longitude
ed25d33
to
0782137
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested yesterday before last forcepush.
Iirc there were only minor changes in the config comments.
The getbool method seems to be the cleanest solution.
Looks good to me.
The following things can now be controlled domain specific:
Hostname, Hardware-Model, Contact Information, VPN, Latitude and Longitude
resolves #65