Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an option to specify VPNProtocols #70

Merged
merged 2 commits into from
Mar 21, 2021

Conversation

AiyionPrime
Copy link
Contributor

This gets rid of fastd for those who don't want it anymore, while letting it be as the default for any current users.

'fastd' is the only valid option, for now,
anything else results in fastd hidden
under software and not called for its version,
therefore this resolves #66

@AiyionPrime
Copy link
Contributor Author

@herbetom, does this suit you as well?

@AiyionPrime
Copy link
Contributor Author

Tested on one of our supernodes as well;
works as intended, if no option, a valid or an invalid one is given.

@herbetom
Copy link
Contributor

Looks okay, i'm testing it later 👍

@AiyionPrime
Copy link
Contributor Author

Thanks

@AiyionPrime
Copy link
Contributor Author

btw, what protocol are you using instead of fastd?

@herbetom
Copy link
Contributor

btw, what protocol are you using instead of fastd?

see here: #66 (comment)

I only checked if #66 is solved with it. It seems that way. What i couldn't easily test is the actual output.

What i tested:

  • no config set
  • VPNProtocol: fastd (as the Default Setting)
  • VPNProtocol: None (as the Default Setting)

@AiyionPrime AiyionPrime changed the title Implement an option to specify a VPNProtocol Implement an option to specify VPNProtocols Feb 16, 2021
@AiyionPrime
Copy link
Contributor Author

Well this is worse than before; the list produces TypeError: unhashable type: 'list'

@AiyionPrime AiyionPrime marked this pull request as draft February 16, 2021 12:45
@AiyionPrime AiyionPrime marked this pull request as ready for review February 16, 2021 13:04
@AiyionPrime
Copy link
Contributor Author

And ready again.

It's getting quite a massacre by now, but @freifunkh runs mesh-announce upstream/master with #63, #64, #69, #70 as well as #71 merged concurrently without problems.

example: https://hannover.freifunk.net/karte/#/en/map/88e640ba7014

@herbetom
Copy link
Contributor

I think the 3 commits should be squashed. They currently contradict each other. That makes applying them a pain.

@AiyionPrime
Copy link
Contributor Author

@herbetom yeah, good idea.
Thoug I think I'll leave them unsquashed until one of Kiels members acked the proposed changes and make less commits of it right before the merge.

'fastd' is the only valid option, for now,
anything else results in fastd hidden
under software and not called for its version,
therefore this resolves ffnord#66
@AiyionPrime AiyionPrime force-pushed the feature_vpn_proto branch 2 times, most recently from 5a9adf8 to 8e13ffe Compare March 21, 2021 14:05
@TobleMiner TobleMiner merged commit c549d31 into ffnord:master Mar 21, 2021
@AiyionPrime AiyionPrime deleted the feature_vpn_proto branch March 21, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

silent failure on systems without fastd
3 participants