add protection for when kernel_quantizer is None #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmitrevs
changed the title
jmitrevs
added
please test
|
I forget if we decided there was a better way of doing this. |
|
Any comments on this PR? Is it ready to merge? |
|
Does it need a test? |
vloncar
force-pushed
the
weight_quantizer_none
branch
from
b6d1005 to
03ea15d
Compare
vloncar
approved these changes
Jun 28, 2024
jmitrevs
added
please test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The hls4ml software assumes that in QKeras, QDense, QConv, etc, will always have kernel_quantizer or similar defined. This fixes the case when they are not, as found in issue #990.
Type of change
Tests
Must first check that this doesn't break other tests. Whether we want to add a test for this particular situation I am not sure.
Checklist
pre-commiton the files I edited or added.