Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split hgq tests and isolate qkeras tests to make tests run in under 1h #1153

Merged
merged 6 commits into from
Dec 14, 2024

Conversation

JanFSchulte
Copy link
Contributor

Attempt to reconfigure pytests so that they reliably finish in under 1h and don't get killed.

The HGQ tests are split into two and both are run standalone. The QKeras test is also added to the list of long-running tests that should not be run in the same batch as other tests.

Type of change

For a new feature or function, please create an issue first to discuss it
with us before submitting a pull request.

Note: Please delete options that are not relevant.

  • Other (Specify)

Tests

No new tests, but hopefully existing ones will pass.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@JanFSchulte
Copy link
Contributor Author

pre-commit.ci autofix

@JanFSchulte JanFSchulte added the please test Trigger testing by creating local PR branch label Dec 13, 2024
@JanFSchulte JanFSchulte added please test Trigger testing by creating local PR branch and removed please test Trigger testing by creating local PR branch labels Dec 13, 2024
@jmitrevs
Copy link
Contributor

Do we need to split even more tests?

@jmitrevs
Copy link
Contributor

Or only merge 3 tests?

@JanFSchulte JanFSchulte added please test Trigger testing by creating local PR branch and removed please test Trigger testing by creating local PR branch labels Dec 14, 2024
@jmitrevs jmitrevs merged commit 3c63e27 into fastmachinelearning:main Dec 14, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please test Trigger testing by creating local PR branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants