Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(userspace/libsinsp): properly set successful lookup state when parsing old container json events #1811

Merged
merged 1 commit into from
Apr 24, 2024
Merged

fix(userspace/libsinsp): properly set successful lookup state when parsing old container json events #1811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions userspace/libsinsp/parsers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5125,6 +5125,11 @@ void sinsp_parser::parse_container_json_evt(sinsp_evt *evt)
container_info->set_lookup_status(sinsp_container_lookup::state::FAILED);
}
}
else
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is useful only for old scap-files

{
// Fallback at successful state
container_info->set_lookup_status(sinsp_container_lookup::state::SUCCESSFUL);
}

const Json::Value& created_time = container["created_time"];
if(check_int64_json_is_convertible(created_time, "created_time"))
Expand Down
Loading