-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(userspace/libsinsp): properly set successful lookup state when parsing old container json events #1811
Conversation
…rsing old container json events. Signed-off-by: Federico Di Pierro <[email protected]>
/milestone 0.16.0 |
Without the change:
With the change:
|
@@ -5125,6 +5125,11 @@ void sinsp_parser::parse_container_json_evt(sinsp_evt *evt) | |||
container_info->set_lookup_status(sinsp_container_lookup::state::FAILED); | |||
} | |||
} | |||
else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is useful only for old scap-files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, leogr, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This PR fixups a small bug indirectly caused by the changes in #1707.
Default at successful lookup state when
lookup_state
is not part of the container json event.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Falco CI uses very very old container events in scap files (prior to 58a546a changes) thus one event was expected but not received becase it had no
lookup_state
field.See https://github.com/falcosecurity/falco/actions/runs/8802240019?pr=3177:
Does this PR introduce a user-facing change?: