Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Falcosidekick servicemonitor port and selector fix #626

Conversation

fa-at-pulsit
Copy link
Contributor

What type of PR is this?

/kind bug

/kind chart-release

Any specific area of the project related to this PR?

/area falcosidekick-chart

What this PR does / why we need it:

fix: mismatch port name in servicemonitor
fix: added component core to selector, overwise prometheus tries to select also falcosidekick-ui (if installed) and fails

Which issue(s) this PR fixes:

Fixes #

fix: mismatch port name in servicemonitor
fix: added component core to selector, overwise prometheus tries to select also falcosidekick-ui (if installed) and fails

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • CHANGELOG.md updated

@poiana poiana added kind/bug Something isn't working dco-signoff: no kind/chart-release Add this label when the chart version has been bumped area/falcosidekick-chart labels Feb 15, 2024
@poiana
Copy link
Contributor

poiana commented Feb 15, 2024

Welcome @fa-at-pulsit! It looks like this is your first PR to falcosecurity/charts 🎉

Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks

@poiana
Copy link
Contributor

poiana commented Feb 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fa-at-pulsit, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the lgtm label Feb 15, 2024
@poiana
Copy link
Contributor

poiana commented Feb 15, 2024

LGTM label has been added.

Git tree hash: 2d961af515830a6d163fe92f17308a90e57efd8c

@Issif
Copy link
Member

Issif commented Feb 15, 2024

Can you sign off your commit please

@fa-at-pulsit fa-at-pulsit force-pushed the falcosidekick_servicemonitor_port_and_selector_fix branch from 49eb0fd to 4a0d860 Compare February 15, 2024 11:08
@fa-at-pulsit
Copy link
Contributor Author

@Issif somehow my sign off is not recognised... should I rebase it and commit again or can you force it?

@Issif
Copy link
Member

Issif commented Feb 15, 2024

Some of your commits are not signed off. You should squash them, sign them off and push force. A rebase could be useful too.

@poiana poiana merged commit 70efc03 into falcosecurity:master Feb 19, 2024
5 checks passed
@tberreis
Copy link
Contributor

I may be wrong but isn't the label app.kubernetes.io/component now set twice?
For example it's added to the deployment here and also to the falcosidekick.labels here.

poiana pushed a commit that referenced this pull request Feb 26, 2024
This commit partly reverts #626

Signed-off-by: Thomas Berreis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/falcosidekick-chart dco-signoff: yes kind/bug Something isn't working kind/chart-release Add this label when the chart version has been bumped lgtm size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants