-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Falcosidekick servicemonitor port and selector fix #626
Falcosidekick servicemonitor port and selector fix #626
Conversation
Welcome @fa-at-pulsit! It looks like this is your first PR to falcosecurity/charts 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch. Thanks
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fa-at-pulsit, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 2d961af515830a6d163fe92f17308a90e57efd8c
|
Can you sign off your commit please |
49eb0fd
to
4a0d860
Compare
@Issif somehow my sign off is not recognised... should I rebase it and commit again or can you force it? |
Some of your commits are not signed off. You should squash them, sign them off and push force. A rebase could be useful too. |
Signed-off-by: Filipp Akinfiev <[email protected]>
4a0d860
to
aad01ba
Compare
This commit partly reverts #626 Signed-off-by: Thomas Berreis <[email protected]>
What type of PR is this?
/kind bug
/kind chart-release
Any specific area of the project related to this PR?
/area falcosidekick-chart
What this PR does / why we need it:
fix: mismatch port name in servicemonitor
fix: added component core to selector, overwise prometheus tries to select also falcosidekick-ui (if installed) and fails
Which issue(s) this PR fixes:
Fixes #
fix: mismatch port name in servicemonitor
fix: added component core to selector, overwise prometheus tries to select also falcosidekick-ui (if installed) and fails
Special notes for your reviewer:
Checklist