Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[falcosidekick] fix: remove duplicate component label #634

Merged
merged 1 commit into from
Feb 26, 2024
Merged

[falcosidekick] fix: remove duplicate component label #634

merged 1 commit into from
Feb 26, 2024

Conversation

tberreis
Copy link
Contributor

What type of PR is this?

/kind bug

/kind chart-release

Any specific area of the project related to this PR?

/area falcosidekick-chart

What this PR does / why we need it:

This PR removes the component label core from within the _helpers.tpl because it is set specific to each component within the corresponding templates - see #626 (comment).

This partly reverts #626.

To reproduce this issue run the following on #626:

git checkout 70efc03efebf52da11199271af161bf7ab0b656c
helm template falco .  --output-dir /dev/shm/70efc03
kubeconform -strict /dev/shm/70efc03/falcosidekick/templates/rbac.yaml

kubeconform will throw the following errors:

/dev/shm/70efc03/falcosidekick/templates/rbac.yaml - ServiceAccount falco-falcosidekick failed validation: error unmarshalling resource: error converting YAML to JSON: yaml: unmarshal errors:
  line 16: key "app.kubernetes.io/component" already set in map
/dev/shm/70efc03/falcosidekick/templates/rbac.yaml - RoleBinding falco-falcosidekick failed validation: error unmarshalling resource: error converting YAML to JSON: yaml: unmarshal errors:
  line 15: key "app.kubernetes.io/component" already set in map
/dev/shm/70efc03/falcosidekick/templates/rbac.yaml - Role falco-falcosidekick failed validation: error unmarshalling resource: error converting YAML to JSON: yaml: unmarshal errors:
  line 15: key "app.kubernetes.io/component" already set in map

Which issue(s) this PR fixes:

Fixes #626

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

This commit partly reverts #626

Signed-off-by: Thomas Berreis <[email protected]>
@poiana poiana added kind/bug Something isn't working dco-signoff: yes kind/chart-release Add this label when the chart version has been bumped labels Feb 26, 2024
@poiana poiana requested review from alacuku and bencer February 26, 2024 10:38
@Issif Issif added this to the 2.29 milestone Feb 26, 2024
@poiana
Copy link
Contributor

poiana commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, tberreis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Feb 26, 2024

LGTM label has been added.

Git tree hash: 81e2884e68673a650e93fb4beb7008d88bc59407

@Issif
Copy link
Member

Issif commented Feb 26, 2024

Thanks

@poiana poiana merged commit 23f9fe8 into falcosecurity:master Feb 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/falcosidekick-chart dco-signoff: yes kind/bug Something isn't working kind/chart-release Add this label when the chart version has been bumped lgtm size/XS
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants