Refactoring Kubernetes recommanded labels for Falco Sidekick #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
kind/cleanup
dco-signoff: yes
kind/chart-release
|
Welcome @mmadoo! It looks like this is your first PR to falcosecurity/charts 🎉 |
mmadoo
force-pushed
the
fix/falcosidekick-labels
branch
from
fdcf9d2 to
fcc5e34
Compare
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
- Use the recommanded label app.kubernetes.io/component for Core and UI resources. - Fix: UI Rbac and secrets resources only generate when webui.enabled is true Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Trangosi <[email protected]>
mmadoo
force-pushed
the
fix/falcosidekick-labels
branch
from
fcc5e34 to
c680694
Compare
Issif
approved these changes
Dec 18, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif, mmadoo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 5f39900c9b784623c825525eac27741204ef2e96
|
This was referenced Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created from #563 I just update CHANGELOG and bump chart version
What type of PR is this?
/kind cleanup
/kind chart-release
/area falcosidekick-chart
What this PR does / why we need it:
Checklist