Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring Kubernetes recommanded labels for Falco Sidekick #563

Closed
wants to merge 6 commits into from
Closed

Refactoring Kubernetes recommanded labels for Falco Sidekick #563

wants to merge 6 commits into from

Conversation

nlamirault
Copy link
Contributor

@nlamirault nlamirault commented Oct 20, 2023 •
edited
Loading

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area event-generator-chart

What this PR does / why we need it:

Manage Kubernetes recommanded labels into a single source (Helm helper file)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@nlamirault
Fix: labels for Falcosidekick
af9b070 
Signed-off-by: Nicolas Lamirault <[email protected]>
@poiana
Copy link
Contributor

poiana commented Oct 20, 2023

Welcome @nlamirault! It looks like this is your first PR to falcosecurity/charts 🎉

@poiana poiana requested review from alacuku and bencer October 20, 2023 15:39
@poiana poiana added the size/S label Oct 20, 2023
@poiana poiana added size/L and removed size/S labels Oct 20, 2023
@nlamirault nlamirault changed the title Fix: labels for Falcosidekick Refactoring Kubernetes recommanded labels for Falco Sidekick Oct 20, 2023
@nlamirault
Fix: do not change ingress ui
fb90ed0 
Signed-off-by: Nicolas Lamirault <[email protected]>
@Issif Issif mentioned this pull request Oct 23, 2023
Closed
3 tasks
@Issif
Copy link
Member

Issif commented Oct 23, 2023

Why have you created the #563 and #564 for the same changes?

Moreover, you need to update the version in the Chart.yaml and the Changelog to pass the CI.

@nlamirault
Add: missing recommanded labels
570dfcd 
Signed-off-by: Nicolas Lamirault <[email protected]>
@nlamirault
Add: missing recommanded labels
d798ff5 
Signed-off-by: Nicolas Lamirault <[email protected]>
@nlamirault
Update: use core and ui labels.
33a33d7 
- Use the recommanded label app.kubernetes.io/component for Core and UI
resources.
- Fix: UI Rbac and secrets resources only generate when webui.enabled is
  true

Signed-off-by: Nicolas Lamirault <[email protected]>
Issif
Issif reviewed Oct 24, 2023
View reviewed changes
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the Chart.yaml and Changelog, it's required by the CI, thanks

@Issif Issif self-assigned this Dec 17, 2023
@Issif Issif closed this Dec 18, 2023
@Issif Issif reopened this Dec 18, 2023
@poiana
Copy link
Contributor

poiana commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nlamirault
Once this PR has been reviewed and has the lgtm label, please ask for approval from issif. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Issif
Copy link
Member

Issif commented Dec 18, 2023

Can you bump the version in the Chart.yaml and update the Changelog.md, thanks

@mmadoo
Copy link
Contributor

mmadoo commented Dec 18, 2023

Can you bump the version in the Chart.yaml and update the Changelog.md, thanks

I add the commit DCbrainOrg@4a857aa but on the repository DCbrainOrg:fix/falcosidekick-labels as nlamirault does not update the PR.
Should I create a new pull request or do you want to update pull request source ?

@Issif
Copy link
Member

Issif commented Dec 18, 2023

I can't update the source by my own, either you create another PR with your fork, either @nlamirault merges your commits into his branch

@mmadoo mmadoo mentioned this pull request Dec 18, 2023
Merged
2 tasks
@Issif
Copy link
Member

Issif commented Dec 18, 2023

I'm closing this PR cause #588 has been merged

@Issif Issif closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Issif Issif Issif left review comments

@alacuku alacuku Awaiting requested review from alacuku

@bencer bencer Awaiting requested review from bencer

Assignees

@Issif Issif

Labels
area/falcosidekick-chart dco-signoff: yes kind/bug Something isn't working size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nlamirault @poiana @Issif @mmadoo