tbv2: account for duplicate types when emitting name providers #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folly::IOBuf does not have TreeBuilder v2 container support. Add it. The implementation is a direct clone of v1. It still lacks tests. Test Plan: - It codegens on a prod type. - No runtime testing... Bad form, I know. - Issue created to add integration tests: facebookexperimental#436
ClangTypeParser has emitted a duplicate type for `std::allocatr<int8_t>`. Rather than fixing this, add the same check the compiler will do for the duplicate templates that `addNames` emits. That is, `template<> NameProvider<Foo>` will collide if `Foo` is used twice. We can do this by adding a set of these strings for now. If this shows up regularly it will likely make sense to deduplicate the type graph with a deduplication pass. Test plan: - Fixes the issue in prod. This change is quite logical.
This was referenced Dec 20, 2023
tyroguru
approved these changes
Dec 20, 2023
tyroguru
approved these changes
Dec 20, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #438 +/- ##
==========================================
- Coverage 44.63% 44.63% -0.01%
==========================================
Files 121 121
Lines 11902 11905 +3
Branches 1946 1947 +1
==========================================
+ Hits 5313 5314 +1
- Misses 5737 5738 +1
- Partials 852 853 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tbv2: account for duplicate types when emitting name providers
ClangTypeParser has emitted a duplicate type for
std::allocatr<int8_t>.Rather than fixing this, add the same check the compiler will do for the
duplicate templates that
addNamesemits. That is,template<> NameProvider<Foo>will collide ifFoois used twice. We can do this byadding a set of these strings for now. If this shows up regularly it will
likely make sense to deduplicate the type graph with a deduplication pass.
Test plan:
Stack created with Sapling. Best reviewed with ReviewStack.