Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Document Bucket Path #105

Merged
merged 21 commits into from
Mar 26, 2024
Merged
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions doc/design/bucketpath.rst
Original file line number Diff line number Diff line change
Expand Up @@ -242,11 +242,11 @@ Pathlike
"""
Removes this directory.

Note: In order to stay close to the pathlib based `rmdir` the default won't delete
non empty direcotries.
Note: In order to stay close to pathlib, by default `rmdir` with `recursive`
set to `False` default won't delete non empty directories.
Nicoretti marked this conversation as resolved.
Show resolved Hide resolved

Args:
recursive: if true the entrie directory and it's entire contents (files and subdirs)
recursive: if true the directory itself and its entire contents (files and subdirs)
will be deleted. If false and the directory is not empty an error will be thrown.

Raises:
Expand Down Expand Up @@ -279,10 +279,10 @@ Pathlike
When the path points to a directory, yield path objects of the directory contents.

Note:
For file like paths it will yield nothing.
If `path` points to a file then `iterdir()` will yield nothing.

Yields:
All direct childs of the pathlike object.
All direct children of the pathlike object.
"""

# Overload / for joining, see also joinpath or `pathlib.Path`.
Expand Down Expand Up @@ -483,7 +483,7 @@ Utilities

Uri = str

def as_udf_path(path: Uri | BUcketPath) -> Pathlike:
def as_udf_path(path: Uri | BucketPath) -> Pathlike:
"""
Convert a BucketPath to a LocalPath (UdfPath).

Expand Down
Loading