Design Document Bucket Path #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkilias
reviewed
Mar 14, 2024
Nicoretti
force-pushed
the
design/bucket-path
branch
from
790c22a to
1d702b5
Compare
tkilias
reviewed
Mar 15, 2024
Nicoretti
force-pushed
the
design/bucket-path
branch
2 times, most recently
from
3464132 to
fcd02b7
Compare
Nicoretti
force-pushed
the
design/bucket-path
branch
from
fcd02b7 to
37284f4
Compare
|
@Nicoretti the PathLike should probably operate on an injected Bucket-object, this way we need to implement the access only ones for SaaS and normal BucketFS and can test with a mock |
ckunki
requested changes
Mar 18, 2024
Co-authored-by: Christoph Kuhnke <[email protected]>
Co-authored-by: Christoph Kuhnke <[email protected]>
Co-authored-by: Christoph Kuhnke <[email protected]>
Co-authored-by: Christoph Kuhnke <[email protected]>
@tkilias I got you covered ;), have a looked at |
Co-authored-by: Christoph Kuhnke <[email protected]>
Co-authored-by: Christoph Kuhnke <[email protected]>
Co-authored-by: Christoph Kuhnke <[email protected]>
Co-authored-by: Christoph Kuhnke <[email protected]>
Co-authored-by: Christoph Kuhnke <[email protected]>
tkilias
reviewed
Mar 22, 2024
tkilias
reviewed
Mar 22, 2024
tkilias
reviewed
Mar 22, 2024
tkilias
reviewed
Mar 22, 2024
tkilias
reviewed
Mar 22, 2024
tkilias
reviewed
Mar 22, 2024
tkilias
reviewed
Mar 22, 2024
tkilias
reviewed
Mar 22, 2024
Co-authored-by: Torsten Kilias <[email protected]>
Co-authored-by: Torsten Kilias <[email protected]>
Co-authored-by: Torsten Kilias <[email protected]>
tkilias
reviewed
Mar 26, 2024
ckunki
requested changes
Mar 26, 2024
Co-authored-by: Christoph Kuhnke <[email protected]>
Co-authored-by: Torsten Kilias <[email protected]>
--- Co-authored-by: Torsten Kilias <[email protected]> Co-authored-by: Christoph Kuhnke <[email protected]> Co-authored-by: Pieterjan Spoelders <[email protected]>
ckunki
requested changes
Mar 26, 2024
Co-authored-by: Christoph Kuhnke <[email protected]>
tkilias
approved these changes
Mar 26, 2024
ckunki
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103