Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#335: Fixed DNS resolution in ITDE when running jupyter notebook tests #336

Merged
merged 5 commits into from
Oct 22, 2024
Merged

#335: Fixed DNS resolution in ITDE when running jupyter notebook tests #336

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
44ec19b
#335: Fixed DNS resolution in ITDE when running jupyter notebook tests
tomuben Oct 18, 2024
c44d912
Updated Ubuntu package ca-certificates
tomuben Oct 18, 2024
e086bb3
Increased DM Ram Size for ITDE
tomuben Oct 21, 2024
85e099e
Increased DM Ram Size for ITDE to 4 GB
tomuben Oct 21, 2024
effd626
[CodeBuild]
tomuben Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions doc/changes/changes_3.2.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,8 @@
Code name:

## Summary


## Bug Fixes

- #335: Fixed DNS resolution in ITDE when running jupyter notebook tests
2 changes: 1 addition & 1 deletion exasol/ds/sandbox/runtime/ansible/roles/docker/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
apt_dependencies:
- apt-transport-https=2.4.5
- gpg-agent=2.2.27-3ubuntu2.1
- ca-certificates=20230311ubuntu0.22.04.1
- ca-certificates=20240203~22.04.1
- software-properties-common=0.99.22.9
2 changes: 1 addition & 1 deletion test/notebook_test_runner/test_notebooks_in_dss_docker_image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def test_notebook(notebook_test_container_with_log, notebook_test_file, notebook
virtual_env = exec_command(command_echo_virtual_env, container)
command_run_test = (
f"{virtual_env}/bin/python"
f" -m pytest --setup-show -s --backend={notebook_test_backend} {notebook_test_file}"
f" -m pytest --setup-show -s --backend={notebook_test_backend} --itde-nameserver='8.8.8.8' {notebook_test_file}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the right thing to do for me, but how did it work before, without --itde-namserver specified explicitly?

Copy link
Contributor

@ckunki ckunki Oct 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but how did it work before?

For this question, we don't have an answer, yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
f" -m pytest --setup-show -s --backend={notebook_test_backend} --itde-nameserver='8.8.8.8' {notebook_test_file}"
f"{virtual_env}/bin/python"
f" -m pytest --setup-show -s"
f" --backend={notebook_test_backend}"
f" --itde-nameserver=8.8.8.8"
f" {notebook_test_file}"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

)
environ = os.environ.copy()
environ["NBTEST_ACTIVE"] = "TRUE"
Expand Down
Loading