Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#335: Fixed DNS resolution in ITDE when running jupyter notebook tests #336

Merged
merged 5 commits into from
Oct 22, 2024
Merged

#335: Fixed DNS resolution in ITDE when running jupyter notebook tests #336

merged 5 commits into from
Oct 22, 2024

Conversation

tomuben
Copy link
Contributor

@tomuben tomuben commented Oct 18, 2024 •
edited
Loading

fixes #335

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@tomuben tomuben temporarily deployed to approve-test-execution October 18, 2024 11:38 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to approve-test-execution October 18, 2024 11:57 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to approve-test-execution October 18, 2024 12:14 — with GitHub Actions Inactive
@tomuben tomuben had a problem deploying to approve-test-execution October 18, 2024 12:35 — with GitHub Actions Failure
@tomuben tomuben temporarily deployed to approve-test-execution October 18, 2024 12:36 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to approve-test-execution October 18, 2024 13:08 — with GitHub Actions Inactive
tomuben
tomuben commented Oct 18, 2024
View reviewed changes
test/notebook_test_runner/test_notebooks_in_dss_docker_image.py Outdated
@@ -81,7 +81,7 @@ def test_notebook(notebook_test_container_with_log, notebook_test_file, notebook
virtual_env = exec_command(command_echo_virtual_env, container)
command_run_test = (
f"{virtual_env}/bin/python"
f" -m pytest --setup-show -s --backend={notebook_test_backend} {notebook_test_file}"
f" -m pytest --setup-show -s --backend={notebook_test_backend} --itde-nameserver='8.8.8.8' --{notebook_test_file}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is the correct way

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, according to the tests this should be ok:
https://github.com/exasol/pytest-plugins/blob/f158045b3045f9065d9d8ce0c16aad3f3806d941/pytest-backend/test/integration/pytest_backend_test.py#L67

@tomuben tomuben temporarily deployed to approve-test-execution October 18, 2024 13:31 — with GitHub Actions Inactive
@tomuben tomuben force-pushed the bug/335_dns_resolution_not_working branch from 3ac953d to 44ec19b Compare October 18, 2024 13:55
@ckunki
Copy link
Contributor

ckunki commented Oct 21, 2024 •
edited
Loading

Currently, some of the sample data is not available, as well as some of the links in the Jupyter notebooks are broken.

E.g. https://archive.ics.uci.edu/static/public/1/abalone.zip shows HTTP Error 502: Bad Gateway

@tomuben tomuben temporarily deployed to approve-test-execution October 21, 2024 18:48 — with GitHub Actions Inactive
@tomuben tomuben merged commit f9aed53 into main Oct 22, 2024
15 checks passed
@tomuben tomuben deleted the bug/335_dns_resolution_not_working branch October 22, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckunki ckunki ckunki approved these changes

@ahsimb ahsimb ahsimb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DNS resolution in ITDE not working in docker-db
3 participants
@tomuben @ckunki @ahsimb