Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(tests) EIP-4200 relative jumps #581

Merged
merged 8 commits into from
Jun 4, 2024
Merged

new(tests) EIP-4200 relative jumps #581

merged 8 commits into from
Jun 4, 2024

Conversation

shemnon
Copy link
Collaborator

@shemnon shemnon commented May 31, 2024

🗒️ Description

Port over ethereum/tests EIP-4200 tests, both validation and execution.
Some duplicate tests were dropped, and some new immediate tests were
added.

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

shemnon and others added 5 commits June 3, 2024 20:46
@shemnon @marioevz
new(tests) EIP-4200 relative jumps
513d519 
Port over ethereum/tests EIP-4200 tests, both validation and execution.
Some duplicate tests were dropped, and some new immediate tests were
added.

Signed-off-by: Danno Ferrin <[email protected]>
@shemnon @marioevz
accidental commit
aba3c14 
Signed-off-by: Danno Ferrin <[email protected]>
@marioevz
fix(tests): EIP-4200: rebase fixes
06dc6e6
@marioevz
fix(fw): Add missing TRUNCATED_INSTRUCTION EOF exception
a5d8897
@marioevz
new(tests): EOF: EIP-4200: more tests
c9b0ac4
marioevz
marioevz approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz marioevz merged commit 5bc2df7 into ethereum:main Jun 4, 2024
5 checks passed
@marioevz marioevz mentioned this pull request Aug 4, 2024
Merged
8 tasks
chfast added a commit to ipsilon/execution-spec-tests that referenced this pull request Oct 25, 2024
@chfast
new(tests): migrate remaining RJUMP* execution tests
bb28248 
The RJUMP/RJUMPI/RJUMPV execution tests were actually migrated
by @shemnon in ethereum#581

This adds just one more basic RJUMPI/RJUMP test.
@chfast chfast mentioned this pull request Oct 25, 2024
Merged
8 tasks
marioevz pushed a commit that referenced this pull request Oct 25, 2024
@chfast
new(tests): EOF - EIP-4200: migrate remaining RJUMP* execution tests (#…
2939e0a 
…916)

The RJUMP/RJUMPI/RJUMPV execution tests were actually migrated
by @shemnon in #581

This adds just one more basic RJUMPI/RJUMP test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shemnon @marioevz