Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(tests): EOF - EIP-4200: migrate remaining RJUMP* execution tests #916

Merged
merged 1 commit into from
Oct 25, 2024
Merged

new(tests): EOF - EIP-4200: migrate remaining RJUMP* execution tests #916

merged 1 commit into from
Oct 25, 2024

Conversation

chfast
Copy link
Member

@chfast chfast commented Oct 25, 2024 •
edited
Loading

🗒️ Description

The RJUMP/RJUMPI/RJUMPV execution tests were actually migrated by @shemnon in #581

This adds just one more basic RJUMPI/RJUMP test.

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened: Remove migrated EOF execution tests tests#1410.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@chfast
new(tests): migrate remaining RJUMP* execution tests
bb28248 
The RJUMP/RJUMPI/RJUMPV execution tests were actually migrated
by @shemnon in ethereum#581

This adds just one more basic RJUMPI/RJUMP test.
@chfast chfast added scope:tests Scope: Test cases type:test Type: Test labels Oct 25, 2024
@pdobacz pdobacz mentioned this pull request Oct 25, 2024
Merged
marioevz
marioevz approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I don't think the coverage will pass since it would have to include the other RJUMP* files in the analysis, so I will override-merge as long as the other checks pass.

@marioevz marioevz changed the title new(tests): migrate remaining RJUMP* execution tests new(tests): EOF - EIP-4200: migrate remaining RJUMP* execution tests Oct 25, 2024
@marioevz marioevz merged commit 2939e0a into ethereum:main Oct 25, 2024
3 of 5 checks passed
@marioevz marioevz deleted the eof/rjump_exec branch October 25, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

@pdobacz pdobacz pdobacz approved these changes

@shemnon shemnon Awaiting requested review from shemnon

@danceratopz danceratopz Awaiting requested review from danceratopz

Assignees
No one assigned
Labels
scope:tests Scope: Test cases type:test Type: Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chfast @pdobacz @marioevz