Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(consume): correctly forward test setup error to hive server #569

Merged
merged 1 commit into from
May 23, 2024
Merged

fix(consume): correctly forward test setup error to hive server #569

merged 1 commit into from
May 23, 2024

Conversation

danceratopz
Copy link
Member

@danceratopz danceratopz commented May 23, 2024 •
edited
Loading

🗒️ Description

  • Correctly forward an error encountered during test setup (in fixtures, for example) to the hive server (this fixes the error observed in the screenshot from hiveview below).
  • Additionally forwards a failure to the hive server if an error occurs during test teardown.

hive_test_error

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md. Skipping
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@danceratopz danceratopz added type:bug Something isn't working scope:pytest Scope: Pytest plugins scope:consume Scope: Consume command suite labels May 23, 2024
@danceratopz danceratopz requested a review from marioevz May 23, 2024 14:49
marioevz
marioevz approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marioevz marioevz merged commit af638de into main May 23, 2024
9 checks passed
danceratopz added a commit to spencer-tb/execution-spec-tests that referenced this pull request May 28, 2024
@danceratopz
fix(consume): correctly forward setup error to hive server (ethereum#569
5bd9513 
)
@danceratopz danceratopz mentioned this pull request May 29, 2024
Merged
7 tasks
@danceratopz danceratopz deleted the fix/pytest_hive/forward-setup-error-to-hive-test-results branch August 23, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

Assignees
No one assigned
Labels
scope:consume Scope: Consume command suite scope:pytest Scope: Pytest plugins type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danceratopz @marioevz