Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rlp): add helpful assert message upon client initialization error in simulator #578

Merged

Conversation

danceratopz
Copy link
Member

@danceratopz danceratopz commented May 29, 2024

πŸ—’οΈ Description

This PR adds a more helpful message in the case that the simulator fails to connect to the client container. Currently, in the UI, we have the somewhat unhelpful:
image

πŸ”— Related Issues

This was initially hidden by the bug fixed in #569.

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md SKIP.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@danceratopz danceratopz added type:feat type: Feature scope:fw Scope: Framework (evm|tools|forks|pytest) labels May 29, 2024
@danceratopz danceratopz requested a review from marioevz May 29, 2024 21:01
@spencer-tb spencer-tb added the scope:consume Scope: Consume command suite label May 30, 2024
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried and tested! LGTM :)

@danceratopz danceratopz merged commit c82ce6e into ethereum:main May 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:consume Scope: Consume command suite scope:fw Scope: Framework (evm|tools|forks|pytest) type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants