You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I tried to outline what the key changes below are from my understanding, I think we could add extra tests for some of these cases, on the off chance clients keep some of the original funcitionality:
Only update the ring buffer starting from the fork block and not including additional ancestors. Maybe add a test to check that additional ancestors are not included.
Before the fork check that the opcode returns the blockhash for blocks within the old blockhash window, zero otherwise. We could extend this to be 256 + 1 blocks before transitioning. After the fork check the same for the appropriate new windon. I believe it should be gradual, so we could check inside and outside this window for each block as the ring buffer is filling up until > 8192 blocks. We could maybe do this all in one test, like a super transition test. :)
BLOCKHASH gas costs, with the new update the opcode gas cost now remains the same. We could add a sanity check for this to make sure clients adhere to this.
ethereum/EIPs#8577
I tried to outline what the key changes below are from my understanding, I think we could add extra tests for some of these cases, on the off chance clients keep some of the original funcitionality:
Originally posted by @spencer-tb in #564 (review)
The text was updated successfully, but these errors were encountered: