Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for EIP-2935 for Devnet-1 #570

Closed
marioevz opened this issue May 24, 2024 · 0 comments
Closed

Update tests for EIP-2935 for Devnet-1 #570

marioevz opened this issue May 24, 2024 · 0 comments

Comments

@marioevz
Copy link
Member

ethereum/EIPs#8577

I tried to outline what the key changes below are from my understanding, I think we could add extra tests for some of these cases, on the off chance clients keep some of the original funcitionality:

  1. Only update the ring buffer starting from the fork block and not including additional ancestors. Maybe add a test to check that additional ancestors are not included.
  2. Before the fork check that the opcode returns the blockhash for blocks within the old blockhash window, zero otherwise. We could extend this to be 256 + 1 blocks before transitioning. After the fork check the same for the appropriate new windon. I believe it should be gradual, so we could check inside and outside this window for each block as the ring buffer is filling up until > 8192 blocks. We could maybe do this all in one test, like a super transition test. :)
  3. BLOCKHASH gas costs, with the new update the opcode gas cost now remains the same. We could add a sanity check for this to make sure clients adhere to this.

Originally posted by @spencer-tb in #564 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants