Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip(tests): Lengthy EIP-2935 test #583

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Conversation

marioevz
Copy link
Member

🗒️ Description

It takes 1hr and 27 minutes to fill this EIP-2935 test, and given that the spec is changed, this test is probably out-of-date too.

So we will be skipping filling this test until #570 is implemented.

image

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added scope:tests Scope: Test cases type:chore Type: Chore labels May 31, 2024
@spencer-tb spencer-tb merged commit 1bdbbd9 into main Jun 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tests Scope: Test cases type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants