Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: Add support for Isthmus #12847

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Config: Add support for Isthmus #12847

wants to merge 3 commits into from

Conversation

vdamle
Copy link
Contributor

@vdamle vdamle commented Nov 6, 2024

config changes to add Isthmus hard fork.

Description

  • config changes to add Isthmus hard fork.

Tests

  • Config test

Additional context

Pre-req to support L2 withdrawals root in the block header in Isthmus hard fork, as outlined in #12044

Metadata

None.

@vdamle vdamle requested review from protolambda, sebastianst and tynes and removed request for protolambda November 6, 2024 15:49
@vdamle vdamle marked this pull request as ready for review November 6, 2024 15:50
@vdamle
Copy link
Contributor Author

vdamle commented Nov 6, 2024

@tynes
Copy link
Contributor

tynes commented Nov 6, 2024

Looks like something is missing in the devnet setup

Traceback (most recent call last):
  File "/usr/lib/python3.10/shutil.py", line 816, in move
    os.rename(src, real_dst)
FileNotFoundError: [Errno 2] No such file or directory: '/var/opt/circleci/data/workdir/packages/contracts-bedrock/state-dump-901-isthmus.json' -> '/var/opt/circleci/data/workdir/.devnet/allocs-l2-isthmus.json'

We desperately need to reduce the number of lines of code required to configure a hardfork, as well as remove the docker compose based devnet in favor of the kurtosis one

@vdamle vdamle requested review from a team as code owners November 11, 2024 16:51
@vdamle
Copy link
Contributor Author

vdamle commented Nov 11, 2024

@tynes I had resolved this issue locally last week when I saw one of the other stacked PRs failing to run a test locally, missed pushing the change upstream to this branch. This PR is ready for re-review now.

I will take the action to identify and work on the docker compose devnet -> kurtosis move.

@@ -34,10 +34,11 @@ enum Fork {
ECOTONE,
FJORD,
GRANITE,
HOLOCENE
HOLOCENE,
ISTHMUS
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a note here since I found that files related to devnet such as state-dump etc. are generated per hard fork, based on this list. When adding a new hard fork, this list must be updated for the input files for the devnet to be generated correctly (you will see errors related to missing state dump files during the build otherwise):

See:

stateDumpPath
dumpState

@vdamle
Copy link
Contributor Author

vdamle commented Nov 18, 2024

This PR has build failures because it is dependent on the changes in op-geth here:

ethereum-optimism/op-geth#399
ethereum-optimism/op-geth#383

will update the op-geth version in go.mod after the above 2 PRs are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants