-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config: Add support for Isthmus #12847
base: develop
Are you sure you want to change the base?
Conversation
📚
|
Looks like something is missing in the devnet setup
We desperately need to reduce the number of lines of code required to configure a hardfork, as well as remove the docker compose based devnet in favor of the kurtosis one |
@tynes I had resolved this issue locally last week when I saw one of the other stacked PRs failing to run a test locally, missed pushing the change upstream to this branch. This PR is ready for re-review now. I will take the action to identify and work on the docker compose devnet -> kurtosis move. |
@@ -34,10 +34,11 @@ enum Fork { | |||
ECOTONE, | |||
FJORD, | |||
GRANITE, | |||
HOLOCENE | |||
HOLOCENE, | |||
ISTHMUS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a note here since I found that files related to devnet such as state-dump
etc. are generated per hard fork, based on this list. When adding a new hard fork, this list must be updated for the input files for the devnet to be generated correctly (you will see errors related to missing state dump files during the build otherwise):
See:
bb28ebc
to
2449a55
Compare
This PR has build failures because it is dependent on the changes in ethereum-optimism/op-geth#399 will update the op-geth version in go.mod after the above 2 PRs are merged. |
config changes to add Isthmus hard fork.
Description
Tests
Additional context
Pre-req to support L2 withdrawals root in the block header in Isthmus hard fork, as outlined in #12044
Metadata
None.