Isthmus: Updates for L2 withdrawals root in header #12767
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdamle
force-pushed
the
vd/l2-withdrawals-root
branch
3 times, most recently
from
d6de586
to
b8de974
Compare
added 11 commits
November 6, 2024 09:36
* add withdrawalsRoot to ExecutionPayload. * add a `BlocksV4` topic to p2p gossip and check for non-empty withdrawalsRoot on v4 topic. * add checks for whether block is type v4 and apply relevant marshal/unmarshal for l2 withdrawals root.
* attributes check * outputV0AtBlock api update * minor type updates
and fixes for a few failures
when computing L2OutputRoot, no need to re-compute the storage root if Isthmus is active.
and fix lint errors
* `RPCResponseCheck` is an interface that currently has a function that validates withdrawals. * There's an implementation of this interface for L1 and L2 * L1's response checker validates that the withdrawals list matches the root in the header. * L2's response checker validates that the withdrawals list is empty when the withdrawalsRoot is not nil
will move to a separate PR
vdamle
force-pushed
the
vd/l2-withdrawals-root
branch
from
b8de974
to
fc6b673
Compare
|
Closing this PR in lieu of the following stacked PRs: 📚
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR proposes changes to add:
L2ToL1MessagePassercontract to theExecutionPayload.v4) for Isthmus blocks.op-programupdate to use thewithdrawalsRootfrom the header, instead of computing the storage rootwhen computing
L2OutputRoot.Tests
Additional context
Addresses changes to Consensus Layer to support L2 withdrawals root in the block header, as outlined in #12044
Spec changes: ethereum-optimism/specs#394
EL changes:
Metadata
None.