Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constructor consistency update #2610

Merged
merged 9 commits into from
Nov 28, 2024
Merged

Constructor consistency update #2610

merged 9 commits into from
Nov 28, 2024

Conversation

bugadani
Copy link
Contributor

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines - Well, I changed the guide 🤔🫠

Extra:

Pull Request Details 📖

Description

Closes #2416

@bugadani bugadani changed the title Construct~ion~or work Constructor consistency update Nov 25, 2024
@bugadani bugadani force-pushed the constructors branch 2 times, most recently from bd72721 to af59ce5 Compare November 25, 2024 18:10
@bugadani bugadani marked this pull request as draft November 25, 2024 18:21
@bugadani bugadani force-pushed the constructors branch 6 times, most recently from 02cf2f4 to 3227ca9 Compare November 26, 2024 16:35
@bugadani bugadani marked this pull request as ready for review November 26, 2024 16:35
bjoernQ
bjoernQ approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MabezDev
MabezDev requested changes Nov 27, 2024
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think we should be explicit in the guidelines that the config error enum is different to a normal error type for the driver

documentation/API-GUIDELINES.md Show resolved Hide resolved
jessebraham
jessebraham approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

MabezDev
MabezDev approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MabezDev MabezDev added this pull request to the merge queue Nov 28, 2024
Merged via the queue into esp-rs:main with commit 92910bf Nov 28, 2024
28 checks passed
@bugadani bugadani deleted the constructors branch November 28, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MabezDev MabezDev MabezDev approved these changes

@bjoernQ bjoernQ bjoernQ approved these changes

@jessebraham jessebraham jessebraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC] How to apply configuration
4 participants
@bugadani @jessebraham @bjoernQ @MabezDev