Small Fixes and Tidy Up #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the correct option worked. However, it was not listed and declared as option.
Reorganize spdlog headers in CSVWriter.h and remove unused imports in other files to clean up code dependencies. Add a compile definition in CMakeLists.txt to resolve missing fmt symbols.
gomezzz
reviewed
Dec 11, 2024
schuhmaj
force-pushed
the
fix-python-option
branch
3 times, most recently
from
dcfc6ef to
0ce6c37
Compare
Replaced hardcoded versioning with a dynamic CMake-driven system using `Info.h` to embed version, parallelization, and commit metadata directly into the build. Simplified Python version parsing and renamed `LOGGING_LEVEL` to `POLYHEDRAL_GRAVITY_LOGGING_LEVEL` for consistency. Consolidated version management and improved Git commit hash handling.
schuhmaj
force-pushed
the
fix-python-option
branch
from
0ce6c37 to
58d17e7
Compare
|
Thank you for the first review. I modernized the process a bit more. The variables are now filled in via CMake and the CI/CD is working. |
gomezzz
approved these changes
Dec 17, 2024
|
Thank you :) The pipeline should be sensitive to detect bugs if there were any 😇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
fmtsymbols using pre-installedspdlogonarmarchitecturespdlogas header library instead of the maybe-present-pre-compiled libraryInfo.h.infile and a correspondingversion.cmakewhich fills in the values__version__,__parallelization__,__commit__and__logging__for the end-user to display compilation details