Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize with Upstream #9

Merged
merged 11 commits into from
Dec 17, 2024
Merged

Synchronize with Upstream #9

merged 11 commits into from
Dec 17, 2024

Conversation

schuhmaj
Copy link
Collaborator

@schuhmaj schuhmaj commented Dec 17, 2024

Changelog

Using the correct option worked. However, it was not listed and declared as option.
Reorganize spdlog headers in CSVWriter.h and remove unused imports in other files to clean up code dependencies. Add a compile definition in CMakeLists.txt to resolve missing fmt symbols.
Replaced hardcoded versioning with a dynamic CMake-driven system using `Info.h` to embed version, parallelization, and commit metadata directly into the build. Simplified Python version parsing and renamed `LOGGING_LEVEL` to `POLYHEDRAL_GRAVITY_LOGGING_LEVEL` for consistency. Consolidated version management and improved Git commit hash handling.
@schuhmaj schuhmaj self-assigned this Dec 17, 2024
@schuhmaj
Copy link
Collaborator Author

@Blauben This shouldn't interfere with your work as mainly the build system is slightly optimized and the main methods log output a fixes some compile errors on ARM devices with missing fmt symbols.

The compile errors are still the same as the ones existing in the current revision main 6f96144
and should be resolved by the fixes you implemented.

Hence, I'll force the merge despite the failing pipeline. If you run into any issues (I've not foreseen), please let me know.

@schuhmaj schuhmaj merged commit cab9e72 into main Dec 17, 2024
0 of 6 checks passed
@schuhmaj schuhmaj deleted the sync-upstream branch December 17, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant