Add pylint to CI #290
Add pylint to CI #290
Conversation
|
See #289 |
| @@ -39,3 +40,7 @@ jobs: | |||
| - name: Lint with flake8 | |||
There was a problem hiding this comment.
Just a question: is the idea that pylint will replace flake8, maybe when its errors have been dealt with? Or do we normally have both on a project?
.pylintrc
Outdated
| @@ -0,0 +1,63 @@ | |||
| [MESSAGES CONTROL] | |||
There was a problem hiding this comment.
Instead of having a dot file to control pylint, it might be preferable to put its options in setup.cfg (and, eventually, pyproject.toml if/when we move to PEP621-style packaging).
The disable list would go into a [pylint.messages control] section of setup.cfg.
There was a problem hiding this comment.
Thanks, that made it prettier. Used setup.cfg.
berland
force-pushed
the
pylint_in_ci
branch
2 times, most recently
from
4de83b7 to
d4715c0
Compare
| @@ -27,6 +27,7 @@ jobs: | |||
|
|
|||
| - name: Install dependencies | |||
| run: | | |||
| pip install . | |||
There was a problem hiding this comment.
@xjules , it seems your comment here has been lost. This line is added in order to let pylint check that everything is importable, so this is used only to get the dependencies in, not to get komodo itself in.
Currently every current pylint issue is exempted. Excemptions (disables) in .pylintrc are to be removed one-by-one in upcoming PRs.
Currently every current pylint issue is exempted.
Excemptions (disables) in .pylintrc are to be removed one-by-one in upcoming PRs.