Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve some pylint issues #297

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Solve some pylint issues #297

merged 1 commit into from
Jan 16, 2023

Conversation

berland
Copy link
Contributor

@berland berland commented Jan 9, 2023

Based off #290

@berland berland force-pushed the pylint-take1 branch 2 times, most recently from 1a15595 to 0304648 Compare January 9, 2023 13:38
@berland berland self-assigned this Jan 9, 2023
@berland berland added the maintenance Not a bug now but could be one day, repaying technical debt label Jan 9, 2023
@lars-petter-hauge
Copy link
Contributor

Could you squash the two commits for Add pylint to ci? (and technically they should have the inverse order, otherwise the commit introducing the pylint would be a failing commit)

xjules
xjules reviewed Jan 10, 2023
View reviewed changes
.github/workflows/style.yml Outdated Show resolved Hide resolved
@berland
Copy link
Contributor Author

berland commented Jan 12, 2023

Could you squash the two commits for Add pylint to ci? (and technically they should have the inverse order, otherwise the commit introducing the pylint would be a failing commit)

Fixed!

@kwinkunks
Copy link
Member

Other than the _id, which is not a big deal at all, I think everything in here looks good. Most of it is a clear improvement, and I learned some things about pylint too.

@berland berland force-pushed the pylint-take1 branch 2 times, most recently from 6ffbad6 to e70acdc Compare January 13, 2023 08:05
kwinkunks
kwinkunks approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@kwinkunks kwinkunks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after small changes. Can't see what might be causing the failed test on Python 3.10.

@berland
Add pylint to ci
1e88067 
Currently every current pylint issue is exempted.

Excemptions (disables) in .pylintrc are to be removed one-by-one in
upcoming PRs.

Solve selected pylint issues
@berland
Copy link
Contributor Author

berland commented Jan 16, 2023

Probably a flaky thing that stopped 3.10. But there was a real pylint issue on 3.10 that needed attention, replaced distutils.dir_util.mkpath with pathlib.Path.mkdir.

@berland berland merged commit 881c71e into equinor:main Jan 16, 2023
@berland berland deleted the pylint-take1 branch September 27, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xjules xjules xjules left review comments

@kwinkunks kwinkunks kwinkunks approved these changes

Assignees

@berland berland

Labels
maintenance Not a bug now but could be one day, repaying technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@berland @lars-petter-hauge @kwinkunks @xjules