Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get media configs in API endpoint #651

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

andchiind
Copy link
Contributor

@andchiind andchiind commented Nov 28, 2024

@andchiind andchiind force-pushed the get-media-token-api branch 4 times, most recently from bcb3095 to 00f36e8 Compare November 28, 2024 13:43
Copy link
Contributor

@sondreo sondreo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! See some minor suggestions.

src/isar/modules.py Outdated Show resolved Hide resolved
src/isar/services/utilities/robot_utilities.py Outdated Show resolved Hide resolved
src/isar/services/utilities/robot_utilities.py Outdated Show resolved Hide resolved
src/isar/apis/models/models.py Show resolved Hide resolved
@andchiind andchiind force-pushed the get-media-token-api branch 4 times, most recently from d3df844 to 5d2efb6 Compare December 2, 2024 13:14
Copy link
Contributor

@sondreo sondreo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andchiind andchiind merged commit 0c37b44 into equinor:main Dec 3, 2024
6 checks passed
@andchiind andchiind deleted the get-media-token-api branch December 3, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants