Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conf path #14

Merged
merged 12 commits into from
Nov 16, 2023
Merged

Add conf path #14

merged 12 commits into from
Nov 16, 2023

Conversation

adnejacobsen
Copy link
Contributor

@adnejacobsen adnejacobsen commented Nov 14, 2023 •
edited
Loading

Add config_path argument to prevent job form failing when global variables is in a different location than fmuconfig/output/global_variables.yml.

@adnejacobsen adnejacobsen marked this pull request as draft November 14, 2023 08:08
@adnejacobsen adnejacobsen mentioned this pull request Nov 14, 2023
Merged
@adnejacobsen adnejacobsen marked this pull request as ready for review November 16, 2023 13:05
@adnejacobsen adnejacobsen requested a review from a team November 16, 2023 13:05
rwiker
rwiker approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@rwiker rwiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@adnejacobsen adnejacobsen merged commit cfac899 into main Nov 16, 2023
8 checks passed
@adnejacobsen adnejacobsen deleted the add-conf-path branch November 16, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwiker rwiker rwiker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adnejacobsen @rwiker