Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conf path #15

Merged
merged 6 commits into from
Nov 16, 2023
Merged

Add conf path #15

merged 6 commits into from
Nov 16, 2023

Conversation

adnejacobsen
Copy link
Contributor

@adnejacobsen adnejacobsen commented Nov 14, 2023

Pass config_path to sumo_upload. sumo_upload will attempt to upload parameters.txt which needs the config to produce metadata using fmu-dataio. This operation is currently failing if the asset has their global variables somewhere other than fmuconfig/output/global_variables.yml. This PR is dependent on a PR in the uploader: equinor/fmu-sumo-uploader#14

@adnejacobsen adnejacobsen marked this pull request as draft November 14, 2023 08:07
@adnejacobsen adnejacobsen marked this pull request as ready for review November 16, 2023 14:30
@adnejacobsen adnejacobsen requested review from daniel-sol and a team November 16, 2023 14:46
@@ -273,6 +280,7 @@ def upload(upload_folder, suffixes, env="prod", threads=5, start_del="real"):
threads (int, optional): Threads to use in upload. Defaults to 5.
"""
logger = logging.getLogger(__file__ + ".upload")
print(f"CONFIG_PATH: {config_path}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switch to logger.debug?

Copy link
Contributor

@daniel-sol daniel-sol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adnejacobsen adnejacobsen merged commit 96a3fba into main Nov 16, 2023
0 of 3 checks passed
@adnejacobsen adnejacobsen deleted the add-conf-path branch November 16, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants