Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test out uv lockfile #9561

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Dec 16, 2024

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@larsevj larsevj force-pushed the test_using_uv_lockfile branch from c5f5714 to e322772 Compare December 16, 2024 13:36
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.69%. Comparing base (9ba5a28) to head (9b23882).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9561      +/-   ##
==========================================
- Coverage   91.90%   91.69%   -0.21%     
==========================================
  Files         433      433              
  Lines       26788    26788              
==========================================
- Hits        24619    24563      -56     
- Misses       2169     2225      +56     
Flag Coverage Δ
cli-tests 39.76% <ø> (+0.02%) ⬆️
everest-models-test ?
gui-tests 72.13% <ø> (-0.03%) ⬇️
integration-test 37.20% <ø> (+0.03%) ⬆️
performance-tests 51.95% <ø> (+0.01%) ⬆️
test 40.69% <ø> (+0.01%) ⬆️
unit-tests 74.17% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 16, 2024

CodSpeed Performance Report

Merging #9561 will not alter performance

Comparing larsevj:test_using_uv_lockfile (9b23882) with main (9ba5a28)

Summary

✅ 24 untouched benchmarks

@larsevj larsevj force-pushed the test_using_uv_lockfile branch from e322772 to 514ee08 Compare December 16, 2024 14:20
@larsevj larsevj force-pushed the test_using_uv_lockfile branch from 0028f57 to 9b23882 Compare December 19, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants