Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to refactor fs #4983

Merged
merged 4 commits into from
Mar 3, 2023
Merged

Add tests to refactor fs #4983

merged 4 commits into from
Mar 3, 2023

Conversation

valentin-krasontovitsch
Copy link
Contributor

Issue
Resolves #4900

This PR replaces 4970 in order to not introduce tons of rebase issues for sloths.

Approach
See commit messages.

See also #4938 (which was closed due to branch on equinor fork) for more context / review history

Pre review checklist

  • Added appropriate release note label
  • SKIPPED! PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • IRRELEVANT Updated documentation
  • Ensured new behaviour is tested

@valentin-krasontovitsch
Copy link
Contributor Author

jenkins, test ert please!

@pinkwah pinkwah force-pushed the enkf_fs_refactor branch from 7095ceb to 491ec4d Compare March 3, 2023 12:42
@valentin-krasontovitsch
Catch unreadable observation config early
127c1f3
@valentin-krasontovitsch
Log gen kw config parsing errors
0565356
@valentin-krasontovitsch
Correct file readable check in config parser
805a6f2
@valentin-krasontovitsch
Add tests for unreadable files
31c49e3 
To make these tests pass fast, we make the default timeout in ensemble
evaluator into a module constant so we can mock it.
@valentin-krasontovitsch valentin-krasontovitsch enabled auto-merge (rebase) March 3, 2023 13:49
@valentin-krasontovitsch valentin-krasontovitsch removed the request for review from oyvindeide March 3, 2023 13:50
@valentin-krasontovitsch valentin-krasontovitsch merged commit a9cd899 into equinor:enkf_fs_refactor Mar 3, 2023
@valentin-krasontovitsch valentin-krasontovitsch deleted the add-tests-to-refactor-fs branch March 3, 2023 13:55
This was referenced Apr 3, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinkwah pinkwah pinkwah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valentin-krasontovitsch @pinkwah